the Creative Commons Attribution 4.0 License.
the Creative Commons Attribution 4.0 License.
Technical Note: The divide and measure nonconformity – how metrics can mislead when we evaluate on different data partitions
Martin Gauch
Frederik Kratzert
Grey Nearing
Jakob Zscheischler
Download
- Final revised paper (published on 13 Aug 2024)
- Supplement to the final revised paper
- Preprint (discussion started on 29 Feb 2024)
Interactive discussion
Status: closed
-
RC1: 'Comment on hess-2024-59', Anonymous Referee #1, 21 Mar 2024
Klotz et al. elucidate the Divide and Measure Nonconformity (aka DAMN) behavior of the NSE-metric. The DAMN can be summarized as; the NSE of a data-series is always higher or equal to the NSE of any subset of this data-series (i.e., the overall NSE of a dataset is not bounded by the NSEs of all its partitions). This behavior not only occurs for the NSE, but for any performance measure that is standardized by observed variance.
Indeed, I was not aware of this behavior, and I deem it relevant for hydrological modellers to be aware of it, and as such I think the very existence of this Technical Note is well justified. The authors provide proof for the DAMN behavior and describe the implications of this behavior.
Although I have little feedback on the technical core of this paper, I think the discussion and presentation can be improved for readability and to increase the relevance. Below, I provide some suggestions that might help the authors.Firstly, it would be more natural to me to move some of the “related work”, namely the whole section on “data splitting”, to a-newly-to-be-added Discussion. The same applies to all the sections under “1.2 Relevance” (besides it seems that “Settings” treats comparable topics as “Data splitting”). The Discussion could then be further enhanced by providing concrete implications and recommendations. Should we no longer use the differential split sample? Are the different NSEs inherently incomparable (I don’t think so – if one doesn’t want to compare model performance to mean observations one should use (R)MSE), or might it just be misleading if you’re not aware of this behavior?).
On the same page, I was wondering if the DAMN phenomenon could be linked to calibration studies. Many studies evaluate the required period for calibration, and conclude that a longer calibration period generally leads to better results (at least for the calibration-period, of course when that is compared to the validation period the DAMN does not apply anymore). This, then, is a combination of the information in the time series that enhances the calibration, and the effect of the DAMN-phenomenon. The relative effect of these two can be disentangled with the LENSE-tool presented here. I was also wondering if the DAMN-phenomenon could have implications for conclusions on overparameterization, but probably not since for this, mostly two independent time periods are used.
From the methods in 2.1 it is not entirely clear why NSElow is fixed to a prescribed value while NSEhigh can vary. After reading the results, I think it does not matter how one would approach it (either fix the high or the low) but this remains a bit unclear in het methods.
I know this is a bit generic, but I have the feeling that 3.1 is not so clearly worked out (hard to follow / to be convinced). Maybe it would help to include some of the arguments treated in Appendix B.
Concerning presentation / figures:
Figure 2: I suppose there is a little hint in showing that surface hydrology class needs fewest preparation hours for the highest grade.. To further emphasize the point of this graph you could add the linear regression line to both panels (1 in the upper and 3 in the lower one).Figure 6 is unclear: what is the yellow line and what are the grey lines? Besides there is a typo in the figure-title (evalauted>evaluated). More in general I would suggest to remove the figure titles, this information can be added/is already present in the caption .
Textual / minor
l. 11 is suited rainfall-runoff -> is suited to simulate rainfall-runoff behavior
l. 10 -15 Note that the criteria you refer to here are meant to evaluate model output, not so much the model itself (because it might depend a lot on implementation and also on data issues). Therefore perhaps good to reword slightly to be more exact on this.
l. 16 metrics -> metric
l. 25 haha. The abbreviation is not in the abstract ;)
l. 29 To be consistent with your definition of t (an index variable) it would be good to rephrase T as the overall number of index variables (mostly time-steps). (also L. 161)
l. 36 ‘Resulting in a lower metric’ -> if the numerator does not change
l. 38 Remove “which”. Besides I’m not entirely sure if I understand these sentences correctly. The squared error term is clear, but then where is the observational variance used?
l. 127 DAMS safe instead of save? (also L.151)
l. 198 smallest instead of thinnest?l. 245-246 Interesting suggestion but the implications or what we learn from it are not directly clear
l. 325 remove one “that”
l. 343 and 349 for clarity perhaps good to keep the order of St and Ot consistent
Appendix A - It is a bit confusing that the mean-symbol is used to express a variance, or did I misunderstand something?
Figure A1 Caption: I don’t understand the last sentence.
Under B1 Generality, for completeness it would be good to clarify if the performance criterion needs to be maximized or minimized.
l. 376 Where is Assumption B2?
Author contributions seems to be placed incorrectly (either before or after all appendices)
l. 510 in the third argument I don’t understand the last sentence.
Lieke Melsen, Wageningen University
Citation: https://doi.org/10.5194/hess-2024-59-RC1 -
AC1: 'Reply on RC1', Daniel Klotz, 12 Apr 2024
We thank the reviewer for the thorough review and constructive feedback. In the following, we provide our answers to the individual comments (where the original comments are written bold).
---
Firstly, it would be more natural to me to move some of the “related work”, namely the whole section on “data splitting”, to a-newly-to-be-added Discussion. The same applies to all the sections under “1.2 Relevance” (besides it seems that “Settings” treats comparable topics as “Data splitting”). The Discussion could then be further enhanced by providing concrete implications and recommendations. Should we no longer use the differential split sample? Are the different NSEs inherently incomparable (I don’t think so – if one doesn’t want to compare model performance to mean observations one should use (R)MSE), or might it just be misleading if you’re not aware of this behavior?).
A similar idea was also raised by reviewer Wouter Knoben, and we do indeed agree that a separated discussion section would be very beneficial for the manuscript. Therefore, we will restructure the manuscript in the proposed way and include a discussion on the recommendations. Our goal for this extended discussion will be the same as for the rest of the paper: To bring more nuance into model evaluation exercises. To shortly answer the reviewer questions here specifically: We believe that differential split sampling should remain a part of the hydrological mode model building toolbox, however modelers should be aware of the DAMN when evaluating their models on differential splits. Similarly, we argue that different NSE values are often somewhat comparable. The DAMN phenomenon makes it so that comparisons get more difficult when the samples are split into partitions with widely different statistical properties (say, rivers/periods with very low variance and rivers/periods with very high variance in streamflow). However, from the “DAMN perspective” it is even then not necessarily wrong to compare the NSEs, modelers should just be aware that these will then not tell the whole story.
On the same page, I was wondering if the DAMN phenomenon could be linked to calibration studies. Many studies evaluate the required period for calibration, and conclude that a longer calibration period generally leads to better results (at least for the calibration-period, of course when that is compared to the validation period the DAMN does not apply anymore). This, then, is a combination of the information in the time series that enhances the calibration, and the effect of the DAMN-phenomenon. The relative effect of these two can be disentangled with the LENSE-tool presented here. I was also wondering if the DAMN-phenomenon could have implications for conclusions on overparameterization, but probably not since for this, mostly two independent time periods are used.
This is an interesting observation. Indeed, when comparing model performance with increasing calibration and validation period lengths, the performance changes will be due to a mix of changes in the actual model quality and of DAMN effects. Therefore, we believe that such evaluations should only increase the calibration period length but keep a fixed validation period (as, for example, in tk feeding camels, tk others?). We are not sure which specific relations to overparameterization the reviewer has in mind, but we also agree that calibration and validation periods are typically (and should always be) entirely separate.
From the methods in 2.1 it is not entirely clear why NSElow is fixed to a prescribed value while NSEhigh can vary. After reading the results, I think it does not matter how one would approach it (either fix the high or the low) but this remains a bit unclear in het methods.
This is correct. Our analysis does not depend on which of the two NSEs is fixed. We chose to fix the lower one, since we were thinking about the risk that a model performs well on most flows but provides bad predictions for peak flows (in our experience this happens easily and the disentangling of performance for specific situations is not simple, as the DAMN shows). We did, however, never describe this explicitly in the manuscript and will add an explanation of the arbitrariness of the choice and a short motivation for it.
I know this is a bit generic, but I have the feeling that 3.1 is not so clearly worked out (hard to follow / to be convinced). Maybe it would help to include some of the arguments treated in Appendix B.
We would like to keep the theoretical treatment in the appendix, but we also do not want readers to get the feeling that a section of the paper is not well worked out. We therefore propose that we extend the section with a discussion of the wider implications of it and not just focus on the specific results of the experiments.
---
Concerning presentation / figures:
Figure 2: I suppose there is a little hint in showing that surface hydrology class needs fewest preparation hours for the highest grade.. To further emphasize the point of this graph you could add the linear regression line to both panels (1 in the upper and 3 in the lower one).
We will add regression lines and change the joke/hint since it was not meant to be offensive (we will exchange it with a less risky alternative that applies to many areas of research; see attached image) .
Figure 6 is unclear: what is the yellow line and what are the grey lines? Besides there is a typo in the figure-title (evalauted>evaluated). More in general I would suggest to remove the figure titles, this information can be added/is already present in the caption .
We will adapt the proposed changes. The color of the lines reflect the difference between NSE and LENSE and go from violet to yellow. The gray lines indicate an explosion of the NSE towards negative infinity, which we clipped at -0.5. However, as the comment rightly points out we did indeed forget to describe any of this (a similar concern was raised in a minor comment from reviewer Wouter). For the revised version we will therefore simplify the plot by truncating first, add a legend to the image and improve the figure caption (see attached document for an example).
---
Textual / minor
l.11 is suited rainfall-runoff -> is suited to simulate rainfall-runoff behavior
Thank you. We will change this part to “is suited to simulate the rainfall-runoff relationship” just because we use “behavior” quite often later in a different context.
l.10 -15 Note that the criteria you refer to here are meant to evaluate model output, not so much the model itself (because it might depend a lot on implementation and also on data issues). Therefore perhaps good to reword slightly to be more exact on this.
Good point. We will rephrase this slightly.
l.16 metrics -> metric
We will change this.
l.25 haha. The abbreviation is not in the abstract ;)
:>
l.29 To be consistent with your definition of t (an index variable) it would be good to rephrase T as the overall number of index variables (mostly time-steps). (also L. 161)
We will do so.
l.36 ‘Resulting in a lower metric’ -> if the numerator does not change
We will change this.
l.38 Remove “which”. Besides, I'm not entirely sure if I understand these sentences correctly. The squared error term is clear, but then where is the observational variance used?
We agree that the sentence is a bit involved, but we feel it is important since we want to already give readers a feeling for the logic behind the LENSE in this part of the manuscript. We will rephrase the sentences in the following way to make it clearer:
One can imagine taking the squared error term (the numerator of the NSE metric) over only the second (orange) partition, but using the observational variance (the denominator of the NSE metric) from the whole (purple) time period. This would result in a value higher than the actual NSE in the second (orange) period.
l.27 DAMS safe instead of save? (also L.151)
Yes indeed.
l. 198 smallest instead of thinnest?We will change this.
l.245-246 Interesting suggestion but the implications or what we learn from it are not directly clear
Thank you. It would make the behavior of the NSE (or whichever metric) clearer and possibly allow (quantitative) comparisons of the “flexibility” of different metrics. We will emphasize this in the revised version.
l.325 remove one “that”
We will change this.
l.343 and 349 for clarity perhaps good to keep the order of St and Ot consistent
We will change this.
Appendix A - It is a bit confusing that the mean-symbol is used to express a variance, or did I misunderstand something?
True. We will use sigma instead.
Figure A1 Caption: I don’t understand the last sentence.
You are right, this is a leftover from an earlier version of the figure. We will remove the sentence.
Under B1 Generality, for completeness it would be good to clarify if the performance criterion needs to be maximized or minimized.
We will explicitly state that we assume that the performance criterion is minimized (and that this, again, does not result in a loss of generality).
l.376 Where is Assumption B2?
Assumption B2 is shown in the form of equation (B2) (l. 369). We agree that this is confusing, because we do not delineate this assumption separately, but make it part of a proposition. In the revised manuscript we will refer to B2 as “the assumption from Eq. (B2)” and adapt l.370, l.376 and l.382 accordingly.
Author contributions seems to be placed incorrectly (either before or after all appendices)
We will move everything after the appendices.
l.510 in the third argument I don’t understand the last sentence.
If the model is good for event A but bad for event B the errors can compensate each other. We will rephrase this.
-
AC1: 'Reply on RC1', Daniel Klotz, 12 Apr 2024
-
RC2: 'HVG Comment on hess-2024-59', Hoshin Gupta, 21 Mar 2024
Nice work folks. Highlights an important issue and points beyond to the issue of proper benchmarking. Please see my edits/comments directly marked on the attached manuscript file. Regards. Hoshin
-
AC2: 'Reply on RC2', Daniel Klotz, 12 Apr 2024
We thank the reviewer for the enthusiastic review! In the following, we will answer the major comments from the review (quoted below in bold). We agree with all the minor suggestions (not quoted below) and will adapt them as proposed by the reviewer.
---
[L. 92ff] This suggests that the problem will persist whenever one uses a locally-sourced benchmark to compute the normalized metric. Would a way around this problem be to always standardize the data in each partition to have the same mean and/or range (I did not think this through)? More generally, if we “understand” that the locally-benchmarked metric indicates only locally-relevant indication of normalized performance, then in principle there is no problem [...]? Perhaps this point could be discussed / made more clear. The problem arises mainly when trying to compare across data splits.
We thought a bit about this interesting proposal and its implications and found that it will lead to an interesting special case, which we will cover in a dedicated subsection of the appendix (see attached document for an exemplary draft) replacing the incomplete discussion of the correlation coefficient. In short, it does seem that the proposed setting will not get rid of the DAMN per se, but focus the evaluation on comparing the rotational similarity of a vector of observations with a vector of simulations.
[L. 230ff] In Schaefli and Gupta (2007) we propose the need to use an “appropriate” “benchmark” for metric normalization (although not the excellent insights you provide here). Perhaps it might be worth mentioning that the “appropriate” benchmark can vary with year [...]. This might be interesting to explore, although it complicates matters by forcing us to think about what the appropriate benchmark prediction is …
This is indeed important. The direction is similar to what we tried to explore with the idea of the SENSE criterion in that the reference model is always derived from the most similar situations (as expressed by the nearest neighbors of a runoff timeframe). The revised manuscript will mention this idea as potential future work.
-
AC2: 'Reply on RC2', Daniel Klotz, 12 Apr 2024
-
RC3: 'Comment on hess-2024-59', Wouter Knoben, 26 Mar 2024
Dear authors,
Thank you for your interesting contribution. I was not aware of this behaviour and I think it's good that this is highlighted to the wider community.
It is known that comparing NSE, KGE and related scores between different basins is not straightforward, and I believe your work shows that even for different periods within the same basin one must be careful with this. In particular, I think your work shows that it may be necessary to revisit studies that compare NSE, KGE or related metric values on overlapping periods of the same data series. Such studies must be re-interpreted with the understanding that for the longer period the score will by definition be either equal or higher than any sub-period but cannot be lower.
I've added a number of annotations and requests for clarifications in the uploaded pdf. I see no scientific issues with this work but a few minor corrections are needed.
-
AC3: 'Reply on RC3', Daniel Klotz, 12 Apr 2024
Thank you for the thorough review! In the following, we will answer the major comments from the review (quoted in bold). We agree with all the minor suggestions (not quoted below) and will adapt them as proposed by the reviewer.
---
[Title] It may be worth considering an addition to this title to briefly outline what the divide and measure nonconformity is.
We will expand the title to: The divide and measure nonconformity: how metrics can mislead when we evaluate on different data partitions.
[L. 46] A key paper missing here is Lamontagne et al. (2020; [...]). These authors draw a distinction between the true value E and its sample estimate NSE, and document NSE's very large variability from one sample to the next. See e.g. their Fig. 4 and accompanying text, as well as their Section 5.4. Their point that values such as NSE and KGE are sample estimates and thus inherently conditional on how the sample is selected, is closely related to your section on Data Splitting. I think it may also be worthwhile to point out Lamontagne's recommendation that NSE should be avoided for use with (sub-)daily data for the these reasons. I may be wrong, but I believe the behaviour you describe in this paper may be a specific consequence of Lamontagne's more general findings about the behaviour of NSE. I do not think that this invalidates the point of this Technical Note, because a more practical and more easily accessible discussion of these concepts is needed.
The paper of Lamontagne et al. (2020) is indeed very relevant and we will include it in the related work. In our eyes it connected to our work in the same fashion as Clark et al. (2021). As such, we view this line of research as complementary to ours: The Lamontagne et al. (2020) line of work deals with problems of estimating a statistical property from small samples, while we explore the implications that partitioning or concatenation of data has for model evaluation. DAMN is not intrinsically a small sample problem, however the two problems can compound. That is, the DAMN phenomenon can appear or increase in small data regimes more easily because the errors in estimation will generally be larger (than in large or infinite data regimes).
[L.55f] I'm reasonably certain that this is the main point of an earlier paper (Schaefli & Gupta, 2007; https://onlinelibrary.wiley.com/doi/10.1002/hyp.6825) and is also implicitly mentioned in Seibert, 2001 (https://onlinelibrary.wiley.com/doi/epdf/10.1002/hyp.446)
We agree and will reference both of these papers.
[L.83] On my second read of the paper I think this section might be better placed as a general discussion section after the experiments and before the conclusions. I think the reader will have a better understanding of the phenomenon at that point and will be more easily able to follow the examples discussed here.
We agree and will adapt the manuscript accordingly.
[L.84] If my understanding of the problem is correct, I believe this generalizes to any study that compares DAMN-susceptible metrics over different periods and draws conclusions based on performance differences.
Yes, this is correct. In the revised version of the manuscript we will make the introduction statement stronger.
[L.163] Because we're looking at a sample estimate of variance, shouldn't the fraction 1/Tr in Eq.3 theoretically be 1/(Tr-1)? This also applies to the NSE (e.g., Lamontagne et al., 2020, Eq. 5b), though I suppose in the NSE case it's slightly easier to assume that (1/n) and (1/(n-1)) approximately cancel out for large enough n. For shorter reference periods Tr this might matter, though I find it hard to judge how much.
We understand where this idea is coming from, but have decided to stick to our original formulation. We would like to bring forth two reasons for our standpoint. For one, the proposed change would somewhat deflect from the purpose of the LENSE (Eq. 3) as a way of thinking about the model performance over an evaluation set with a performance reference model over a reference set. The second point is that the proposed correction would not make the (hypothetical) estimation unbiased either:
For our argument regarding the statistical appropriateness of the proposed change, let us adopt the formalism of Lamontagne et al. (2020) and interpret the LENSE as an approximation to a theoretical construct, which is the ratio of a expectation for a hypothetical distribution of squared errors and the variance of a hypothetical distribution of observations. In that case, it would generally not suffice to use unbiased estimators for the numerator and the denominator to get an unbiased estimator of the ratio!
To see this, consider a scenario where the numerator n and the denominator d are both 1, but we can only estimate d with an unbiased precision of ±0.5. In this case, if the estimation of the variance from given data would result in an underestimation of e, say, of ê=0.5, this will result in an overestimation of the actual ratio, since we would estimate it to be 2. However, an overestimation with the same delta, i.e., ê=1.5 will result in an estimated ratio of 0.66 (because we are only linear in log-space). Hence, in expectation our estimator would still be biased (since we would overestimate the ratio and thus underestimate the LENSE).
This argument also seems to be appreciated in statistical arguments/literature (e.g., section 4 in Olkin and Pratt, 1958).
For us it does therefore not appear to be correct to say that NSE (or the LENSE) is an unbiased estimator for a hypothetical true NSE (or the LENSE) — and, in our eyes, the same holds true for the statement made in Lamontagne et al. (2020). Hence, we will keep our formulation as it is since we view it as more elegant and also more similar to the way the NSE is actually used in practice.
Reference: Olkin, I., & Pratt, J. W. (1958). Unbiased estimation of certain correlation coefficients. The annals of mathematical statistics, 201-211.
[L.165] Can it be clarified what the added value is of dividing the MSE of each partition by what's effectively a constant? Is it just that we retain a reference model and therefore the interpretation of NSE > 0?
I don't think that's a bad thing as such, but it would be good to clarify why this special case is more helpful than just looking at the MSE (which, to my understanding, will always be bounded by the MSE values of the partitions).
Yes. This is correct. If one would use the LENSE then its advantage over the MSE would be that it has a similar interpretation of the meaning of 1 and the 0 that the NSE has. We will clarify this in the revised manuscript.
[Figure caption for Fig.4] It might be interesting to show Is = 0 in a specific different color because this could be considered the "intuitive range" of Eq. 2
The argumentation makes sense and we therefore tried to color 0 separately but did not like the visual clutter (see provided example in the attached document). We therefore prefer to keep the figure as is, but will add the resulting figure to Appendix D).
[L. 205ff] I'm not convinced presenting this analysis as CDFs is very meaningful. Even though both metrics have the same range <-inf, 1], the interpretation of each within that range, I assume, is not necessarily the same.
While we agree that the interpretation is not necessarily the same (what remains is the meaning of 1 as perfect predictions and 0 as the point where the simulation is as good an estimator for the evaluation set as the mean is an estimator for the reference set), we believe the CDF nicely illustrates the offset that is caused by the change in measures.
One aspect that is also lost this way is the per-case comparison: what is the relation between LENSE and NSE for the collection of individual cases? I could be interesting to add a scatter plot of NSE vs LENSE to see if anything meaningful appears.
We agree with the observation that the individual case relation is lost. We will add a scatter plot (see attached document) and discuss it in the revised manuscript.
[L.230ff] This is essentially the same recommendation as Schaefli & Gupta (2007), as well as others, have made. I think your work gives a mathematical explanation for this, but also highlights a related but different problem: that NSE and similar scores cannot easily be compared between different periods for the same basin. I think this is a key contribution that deserves mention here and in the abstract, because the consequences are quite far-reaching.
We agree and will mention it here and in the abstract.
[L.255f] I appreciate that the code is available. I noticed in the online readme that the simulations themselves will be made available after peer review. I think that's a good idea because it's a bit cumbersome having to run the full training procedure to get a few hydrographs to work with, and I couldn't manage to get this done within a reasonable time frame. That said, the results here are not conditional on how the simulations were generated. Some fiddling around with my own data did not provide any evidence that would contrast the statements in this paper.
Thank you. We completely agree with this assessment.
Couple of code comments:
run-grid-experiment.py
- l142, l156. Is the "eps" inside the brackets strictly necessary? It seems to me that the one outside the brackets would prevent any divide-by-zero errors on its own, whereas the one inside the brackets increases the denominator by a bit but doesn't do much else.
No, your are right, it is not necessary. It just a remainder comes from the paranoid stance of the first author while doing experiments. As stated in the comment it does not have an influence on the results.
run-lense-experiment.py
- l88. Is this unit conversion step correct? Unless I'm mistaken somewhere, the first coefficient should be 28.316846592, not 28316846.592
The conversion should be correct. The factor 28.316846592 would convert from feet to liters, but we convert to mm.
Citation: https://doi.org/10.5194/hess-2024-59-AC3
-
AC3: 'Reply on RC3', Daniel Klotz, 12 Apr 2024
Peer review completion
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_open_symbol_running_text.jpg)
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_close_symbol_running_text.jpg)
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_open_symbol_running_text.jpg)
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_close_symbol_running_text.jpg)
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_open_symbol_running_text.jpg)
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_close_symbol_running_text.jpg)
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_open_symbol_running_text.jpg)
![](https://www.hydrology-and-earth-system-sciences.net/graphic_grey_close_symbol_running_text.jpg)